Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigate to a new screen and back (add stronger iOS support) #11776

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Navigate to a new screen and back (add stronger iOS support) #11776

merged 3 commits into from
Mar 5, 2025
+188 −36

Conversation

antfitch
Copy link
Contributor

@antfitch antfitch commented Mar 4, 2025

Description of what this PR is changing or adding, and why:

  • Merged the iOS topic at the bottom of the guide into the existing recipe so that a developer can quickly toggle between Android and iOS steps.

  • Added additional code snippet tests for the iOS samples.

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@antfitch antfitch requested review from sfshaza2, parlough and a team as code owners March 4, 2025 23:34
@antfitch antfitch self-assigned this Mar 4, 2025
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Mar 4, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 417a15b):

https://flutter-docs-prod--pr11776-ios-nav-basics-recipe-dlzkpxdp.web.app

sfshaza2
sfshaza2 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sfshaza2
Copy link
Contributor

sfshaza2 commented Mar 5, 2025

Ah, @antfitch, please run format on the code. Otherwise, lgtm

@antfitch
Copy link
Contributor Author

antfitch commented Mar 5, 2025

Ah, @antfitch, please run format on the code. Otherwise, lgtm

On it! ^_^

@antfitch antfitch merged commit 32ec393 into flutter:main Mar 5, 2025
9 checks passed
@antfitch antfitch deleted the ios_nav_basics_recipe branch March 5, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@parlough parlough Awaiting requested review from parlough parlough is a code owner

Assignees

@antfitch antfitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antfitch @flutter-website-bot @sfshaza2